Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] Fix issue with build order lines table #8376

Merged
merged 4 commits into from
Oct 28, 2024
Merged

[Bug] Fix issue with build order lines table #8376

merged 4 commits into from
Oct 28, 2024
+13 −2

Conversation

SchrodingersGat
Copy link
Member

@SchrodingersGat SchrodingersGat commented Oct 28, 2024 •
edited
Loading

  • Bug introduced in [WIP] Build line filter fix #8343
  • Inadvertently removed the "allocations" field
  • Is crucial for displaying the "allocations" in the build order tables!

@SchrodingersGat
Revert change to BuildItem API
904e056 
- Requires "allocations" for build output table
- Probably can refactor this later
@SchrodingersGat
Bug fix for BuildOutputTable in PUI
b53cbdb 
- Correct calculation for "fully allocated"
@SchrodingersGat
Adjust annotations for serializer
6de7638
@SchrodingersGat SchrodingersGat added bug Identifies a bug which needs to be addressed user interface User interface api Relates to the API build Build orders Platform UI Related to the React based User Interface labels Oct 28, 2024
@SchrodingersGat SchrodingersGat added this to the 0.17.0 milestone Oct 28, 2024
@netlify Netlify
Copy link

netlify bot commented Oct 28, 2024 •
edited
Loading

✅ Deploy Preview for inventree-web-pui-preview ready!

Name Link
🔨 Latest commit 2497411
🔍 Latest deploy log https://app.netlify.com/sites/inventree-web-pui-preview/deploys/671f23758084fe0008ea6655
😎 Deploy Preview https://deploy-preview-8376--inventree-web-pui-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 100 (no change from production)
Accessibility: 86 (🔴 down 3 from production)
Best Practices: 100 (no change from production)
SEO: 78 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov Codecov
Copy link

codecov bot commented Oct 28, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 84.44%. Comparing base (9fd882f) to head (2497411).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
src/frontend/src/tables/build/BuildOutputTable.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #8376      +/-   ##
==========================================
+ Coverage   84.36%   84.44%   +0.07%     
==========================================
  Files        1167     1167              
  Lines       53054    53055       +1     
  Branches     1947     1947              
==========================================
+ Hits        44760    44801      +41     
+ Misses       7809     7760      -49     
- Partials      485      494       +9
Flag Coverage Δ
backend 85.98% <100.00%> (+<0.01%) ⬆️
pui 67.58% <0.00%> (+0.43%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SchrodingersGat SchrodingersGat merged commit 6953640 into inventree:master Oct 28, 2024
26 checks passed
@SchrodingersGat SchrodingersGat deleted the bo-fix branch October 28, 2024 06:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
api Relates to the API bug Identifies a bug which needs to be addressed build Build orders Platform UI Related to the React based User Interface user interface User interface
Projects
None yet
Milestone
0.17.0
Development

Successfully merging this pull request may close these issues.
1 participant
@SchrodingersGat